sky/framework/sky-input.sky - Issue 872233002: Switch KeyboardEvents over to NewEventHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/framework/sky-input.sky

Issue 872233002: Switch KeyboardEvents over to NewEventHandler (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Rename virtualKeyCode to key Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/framework/sky-input.sky

diff --git a/sky/framework/sky-input.sky b/sky/framework/sky-input.sky

index 9ebbaedbf601570365d311ff2b9558a36930f015..5f1130bd0470cbb681fb8a6cdb952ee4d3ce2673 100644

--- a/sky/framework/sky-input.sky

+++ b/sky/framework/sky-input.sky

@@ -57,7 +57,7 @@ module.exports = class extends SkyElement {

}

handleKeyDown(event) {

// TODO(abarth): You can still get newlines if the user pastes them.

- if (event.keyCode == 0xD)

+ if (event.key == 0xD)

event.preventDefault();

}

handleFocus(event) {

« no previous file with comments | « sky/engine/web/WebViewImpl.cpp ('k') | sky/tests/services/event-sender.sky » ('j') | no next file with comments »