Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: sky/engine/web/ChromeClientImpl.cpp

Issue 872233002: Switch KeyboardEvents over to NewEventHandler (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Rename virtualKeyCode to key Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/web/ChromeClientImpl.h ('k') | sky/engine/web/WebInputEventConversion.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/web/ChromeClientImpl.cpp
diff --git a/sky/engine/web/ChromeClientImpl.cpp b/sky/engine/web/ChromeClientImpl.cpp
index 28c3319093f850b7dd5850f82ce449d1385f7383..92d024b690133771b5009b471885295506ffc198 100644
--- a/sky/engine/web/ChromeClientImpl.cpp
+++ b/sky/engine/web/ChromeClientImpl.cpp
@@ -61,7 +61,6 @@
#include "sky/engine/public/web/WebTextDirection.h"
#include "sky/engine/public/web/WebTouchAction.h"
#include "sky/engine/public/web/WebViewClient.h"
-#include "sky/engine/web/WebInputEventConversion.h"
#include "sky/engine/web/WebLocalFrameImpl.h"
#include "sky/engine/web/WebSettingsImpl.h"
#include "sky/engine/web/WebViewImpl.h"
@@ -288,20 +287,4 @@ void ChromeClientImpl::showImeIfNeeded()
m_webView->client()->showImeIfNeeded();
}
-// FIXME: Remove this code once we have input routing in the browser
-// process. See http://crbug.com/339659.
-void ChromeClientImpl::forwardInputEvent(
- Frame* frame, Event* event)
-{
- WebLocalFrameImpl* webFrame = WebLocalFrameImpl::fromFrame(toLocalFrame(frame));
-
- // This is only called when we have out-of-process iframes, which
- // need to forward input events across processes.
- // FIXME: Add a check for out-of-process iframes enabled.
- if (event->isKeyboardEvent()) {
- WebKeyboardEventBuilder webEvent(*static_cast<KeyboardEvent*>(event));
- webFrame->client()->forwardInputEvent(&webEvent);
- }
-}
-
} // namespace blink
« no previous file with comments | « sky/engine/web/ChromeClientImpl.h ('k') | sky/engine/web/WebInputEventConversion.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698