sky/engine/web/ChromeClientImpl.h - Issue 872233002: Switch KeyboardEvents over to NewEventHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/web/ChromeClientImpl.h

Issue 872233002: Switch KeyboardEvents over to NewEventHandler (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: nits Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/web/ChromeClientImpl.h

diff --git a/sky/engine/web/ChromeClientImpl.h b/sky/engine/web/ChromeClientImpl.h

index 019e968bfa8cffd8d64953aedc58e44fa745a99f..bf791f189d8f1da6bed5bc1cb8dfefeac30f795d 100644

--- a/sky/engine/web/ChromeClientImpl.h

+++ b/sky/engine/web/ChromeClientImpl.h

@@ -87,10 +87,6 @@ public:

// ChromeClientImpl:

void setNewWindowNavigationPolicy(WebNavigationPolicy);

- // FIXME: Remove this method once we have input routing in the browser

- // process. See http://crbug.com/339659.

- virtual void forwardInputEvent(Frame*, Event*) override;

virtual void willSetInputMethodState() override;

virtual void didUpdateTextOfFocusedElementByNonUserInput() override;

virtual void showImeIfNeeded() override;