examples/browser/browser.sky - Issue 872233002: Switch KeyboardEvents over to NewEventHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: examples/browser/browser.sky

Issue 872233002: Switch KeyboardEvents over to NewEventHandler (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: nits Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: examples/browser/browser.sky

diff --git a/examples/browser/browser.sky b/examples/browser/browser.sky

index ef3aa2fb05594b847e988e97db4a4dc981630737..8ac4188cbc83c33535f3a85df44a0af59303376c 100644

--- a/examples/browser/browser.sky

+++ b/examples/browser/browser.sky

@@ -31,7 +31,7 @@ module.exports = class extends SkyElement {

}

handleKeyDown(event) {

- if (event.keyCode == 0xD)

+ if (event.virtualKeyCode == 0xD)

this.embedder.navigateTo(this.url);

}

}.register();

« no previous file with comments | « no previous file | sky/engine/core/dom/Node.h » ('j') | sky/engine/core/events/KeyboardEvent.h » ('J')