Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 872153002: Restore debug allocator functions. (Closed)

Created:
5 years, 11 months ago by Will Harris
Modified:
5 years, 11 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, wfh+watch_chromium.org, erikwright+watch_chromium.org, Dai Mikurube (NOT FULLTIME)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore debug allocator functions. These are needed for Debug builds when using allocator_shim. These were accidently removed in r312720. BUG=451663 TEST=base_unittests, allocator_unittests (Debug, component=static_library) Committed: https://crrev.com/c324546cf857bae485efb9a2d80eec6d50d18ed5 Cr-Commit-Position: refs/heads/master@{#313108}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -0 lines) Patch
M base/allocator/allocator_shim_win.cc View 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Will Harris
Turns out we don't have any Debug component=static_library bots, because we can't link Debug static ...
5 years, 11 months ago (2015-01-24 07:29:14 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
5 years, 11 months ago (2015-01-26 19:13:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872153002/1
5 years, 11 months ago (2015-01-26 19:14:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 20:06:16 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 20:07:07 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c324546cf857bae485efb9a2d80eec6d50d18ed5
Cr-Commit-Position: refs/heads/master@{#313108}

Powered by Google App Engine
This is Rietveld 408576698