Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 872143006: Revert "Add namespace sandbox to about page." (Closed)

Created:
5 years, 10 months ago by rickyz (no longer on Chrome)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org, jln+watch_chromium.org, jln (very slow on Chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Add namespace sandbox to about page." Reason for revert: See crbug/456993. This reverts commit 1ef7ee1ee899087d8632a4f905a3a11697a20b81. TBR=jln,jhawkins,nasko,mdempsky BUG=456993 Original issue's description: > Add namespace sandbox to about page. > > This unindents the lines about PID/network namespaces, since those now > apply to both the setuid or unprivileged namespace sandbox. > > BUG=312380 > Committed: https://crrev.com/1ef7ee1ee899087d8632a4f905a3a11697a20b81 > Cr-Commit-Position: refs/heads/master@{#315116} Committed: https://crrev.com/30c2c5d06c4cb04fda4985481155c5fc9c36d846 Cr-Commit-Position: refs/heads/master@{#315541}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -32 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 2 chunks +19 lines, -12 lines 0 comments Download
M content/common/sandbox_linux/sandbox_linux.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M content/public/common/sandbox_linux.h View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
rickyz (no longer on Chrome)
5 years, 10 months ago (2015-02-10 09:37:33 UTC) #2
magjed_chromium
lgtm
5 years, 10 months ago (2015-02-10 09:42:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872143006/1
5 years, 10 months ago (2015-02-10 09:43:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/41657)
5 years, 10 months ago (2015-02-10 09:48:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872143006/1
5 years, 10 months ago (2015-02-10 11:03:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-10 11:58:47 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 11:59:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30c2c5d06c4cb04fda4985481155c5fc9c36d846
Cr-Commit-Position: refs/heads/master@{#315541}

Powered by Google App Engine
This is Rietveld 408576698