Now starting AppRTC server up in "developer mode".

copy_apprtc.py

 #!/usr/bin/python
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Moves Apprtc to the out/ directory, where the browser test can find it.
 
 This copy will resolve symlinks on all platforms, which is useful for Apprtc
 since it uses symlinks for its common javascript files (and Windows does not
 understand those symlinks).
 """
 
+import fileinput
 import os
 import shutil
+import sys
 
 import utils
 
-if __name__ == '__main__':
-  target_dir = os.path.join('src', 'out', 'webrtc-samples')
+
+def _ConfigureApprtcServerToDeveloperMode(apprtc_dir):
+  app_yaml_path = os.path.join(apprtc_dir, 'app.yaml')
+  if not os.path.exists(app_yaml_path):
+    return 'Expected app.yaml at %s.' % os.path.abspath(app_yaml_path)
+
+  for line in fileinput.input(app_yaml_path, inplace=True):
+    # We can't click past these in the firefox interop test, so
+    # disable them.
+    line = line.replace('BYPASS_JOIN_CONFIRMATION: false',
+                        'BYPASS_JOIN_CONFIRMATION: true')
+    sys.stdout.write(line)
+
+
+def _CopyApprtcToTargetDir(target_dir, apprtc_subdir):

[phoglund_chromium, 2015/01/29 13:00:14]

The more I think about it, this should really be a build action. I'll consider
making it that later.

[kjellander_chromium, 2015/01/29 13:11:15]

Yeah, our hooks starts growing out of control here. I guess we should put
together a buildbot script that does all the stuff that's happening in the
hooks, as a separate step (preferably with annotated output so buildbot will
parse it into even more steps).

[phoglund_chromium, 2015/01/29 13:46:24]

Hm, yeah. The downloading and syncing stuff should happen in the buildbot code
and the "building" (i.e. moving and modifying the apprtc code, building closure)
should be a gyp action. I can try to look into that later.

   if utils.GetPlatform() is 'win':
     # Work around the fact that node_modules create ridiculously long paths.
     # Unfortunately shutil will choke on those on Windows, but not rmdir.
     os.system('rmdir /s /q %s' % target_dir)

[kjellander_chromium, 2015/01/29 13:11:15]

Will we catch errors if this fails? It seems like we can check the exit code:
https://docs.python.org/2/library/os.html#os.system
Even if we can't recover, it would make debugging easier if we know a removal
failed (i.e. we print an error message).

[phoglund_chromium, 2015/01/29 13:46:24]

Yeah. Actually I realize I can remove this because I've fixed so that the long
paths never get generated (at least for now). We'll run into trouble anyway in
other places if the paths are allowed to get too long, so this special case
doensn't add anything.

   else:
     shutil.rmtree(target_dir, ignore_errors=True)
   shutil.copytree('webrtc-samples',
                   target_dir, ignore=shutil.ignore_patterns('.svn', '.git'))
-  apprtc_subdir = os.path.join('samples', 'web', 'content', 'apprtc')
 
   # This file is symlinked on windows, so copy it since win doesn't understand
   # symlinks.
   shutil.copyfile(os.path.join('webrtc-samples', 'samples', 'web',
                                'js', 'adapter.js'),
                   os.path.join(target_dir, apprtc_subdir, 'js', 'adapter.js'))
+
+
+def Main():

[kjellander_chromium, 2015/01/29 13:11:15]

nit: the Chromium style guide says the main function should be named all
lowercase.

[phoglund_chromium, 2015/01/29 13:46:24]

Done.

+  target_dir = os.path.join('src', 'out', 'webrtc-samples')
+  apprtc_subdir = os.path.join('samples', 'web', 'content', 'apprtc')
+  _CopyApprtcToTargetDir(target_dir, apprtc_subdir)
+  _ConfigureApprtcServerToDeveloperMode(os.path.join(target_dir, apprtc_subdir))
+
+if __name__ == '__main__':
+  sys.exit(Main())
+