Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 872093002: [Ozone-DRI] Check the host_id when resetting the cursor IPC callback (Closed)

Created:
5 years, 11 months ago by dnicoara
Modified:
5 years, 11 months ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ozone-DRI] Check the host_id when resetting the cursor IPC callback When the GPU process crashes we can get an OnChannelEstablished() before the OnChannelDestroyed() is received. Use the host_id to figure out if the OnChannelDestroyed() should be processed. BUG=451584 Committed: https://crrev.com/5c0f0e0fd056bb8eaaf1c2215fe664a1e8466cde Cr-Commit-Position: refs/heads/master@{#312968}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M ui/ozone/platform/dri/dri_cursor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/dri_cursor.cc View 1 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dnicoara
PTAL
5 years, 11 months ago (2015-01-23 22:33:31 UTC) #2
spang
https://codereview.chromium.org/872093002/diff/1/ui/ozone/platform/dri/dri_cursor.h File ui/ozone/platform/dri/dri_cursor.h (right): https://codereview.chromium.org/872093002/diff/1/ui/ozone/platform/dri/dri_cursor.h#newcode107 ui/ozone/platform/dri/dri_cursor.h:107: int host_id; you need to initialize it
5 years, 11 months ago (2015-01-23 22:44:37 UTC) #3
dnicoara
https://codereview.chromium.org/872093002/diff/1/ui/ozone/platform/dri/dri_cursor.h File ui/ozone/platform/dri/dri_cursor.h (right): https://codereview.chromium.org/872093002/diff/1/ui/ozone/platform/dri/dri_cursor.h#newcode107 ui/ozone/platform/dri/dri_cursor.h:107: int host_id; On 2015/01/23 22:44:37, spang wrote: > you ...
5 years, 11 months ago (2015-01-23 22:51:00 UTC) #4
spang
lgtm
5 years, 11 months ago (2015-01-23 22:51:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872093002/20001
5 years, 11 months ago (2015-01-23 22:52:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-23 23:44:22 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 23:45:55 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c0f0e0fd056bb8eaaf1c2215fe664a1e8466cde
Cr-Commit-Position: refs/heads/master@{#312968}

Powered by Google App Engine
This is Rietveld 408576698