Ease selection dragging between large/small text lines

Ease selection dragging between large/small text lines

Previously, the coordinate sent for adjusting the text selection was
offset from the line by half the line height. The side effect is that
dragging up/down from large lines, particularly to smaller lines, was
difficult, and sometimes even impossible.

Resolve this by using the smaller of fixed size offset and half the
line height. This eases dragging the selection bounds between lines
that differ greatly in size.

BUG=450640
Committed: https://crrev.com/dd0f0e5da45ede84f56f7d50aee23ab13a1b96f2
Cr-Commit-Position: refs/heads/master@{#312982}

[jdduke (slow), 2015-01-23 22:23:08]

jdduke@chromium.org changed reviewers:
+ mohsen@chromium.org

[jdduke (slow), 2015-01-23 22:23:09]

mohsen@: PTAL, thanks.

[jdduke (slow), 2015-01-23 23:17:00]

jdduke@chromium.org changed reviewers:
+ mfomitchev@chromium.org

[jdduke (slow), 2015-01-23 23:17:00]

Or mfomitchev@ if you've already looked at this, feel free to review, thanks.

[mohsen, 2015-01-23 23:35:07]

LGTM

https://codereview.chromium.org/872083002/diff/1/ui/touch_selection/touch_sel...
File ui/touch_selection/touch_selection_controller_unittest.cc (right):

https://codereview.chromium.org/872083002/diff/1/ui/touch_selection/touch_sel...
ui/touch_selection/touch_selection_controller_unittest.cc:752: // The drag
coordinate for large lines should have be capped to a reasonable
nit: should have be capped -> should be capped?

[jdduke (slow), 2015-01-23 23:55:23]

https://codereview.chromium.org/872083002/diff/1/ui/touch_selection/touch_sel...
File ui/touch_selection/touch_selection_controller_unittest.cc (right):

https://codereview.chromium.org/872083002/diff/1/ui/touch_selection/touch_sel...
ui/touch_selection/touch_selection_controller_unittest.cc:752: // The drag
coordinate for large lines should have be capped to a reasonable
On 2015/01/23 23:35:07, mohsen wrote:
> nit: should have be capped -> should be capped?

Ah, good catch, fixed.

[jdduke (slow), 2015-01-23 23:55:26]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2015-01-23 23:56:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/872083002/20001

[commit-bot: I haz the power, 2015-01-24 00:44:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-24 00:45:24]

Patchset 2 (id:??) landed as
https://crrev.com/dd0f0e5da45ede84f56f7d50aee23ab13a1b96f2
Cr-Commit-Position: refs/heads/master@{#312982}