Add patheffects to debugger printout

Add patheffects to debugger printout

TBR=bsalomon@google.com

Committed: https://skia.googlesource.com/skia/+/42dbfa8651861f2f686879c996aab9f9f82277dd

[robertphillips, 2015-01-23 20:42:46]

robertphillips@google.com changed reviewers:
+ egdaniel@google.com

[egdaniel, 2015-01-23 20:56:02]

https://codereview.chromium.org/872043002/diff/1/include/core/SkPathEffect.h
File include/core/SkPathEffect.h (right):

https://codereview.chromium.org/872043002/diff/1/include/core/SkPathEffect.h#...
include/core/SkPathEffect.h:191: SK_TO_STRING_OVERRIDE()
You don't see to implement this to_string so I'm assuming you meant to just use
PairPathEffect's implementation. If this is the case do you need the override
here?

https://codereview.chromium.org/872043002/diff/1/include/core/SkPathEffect.h#...
include/core/SkPathEffect.h:210: class SkSumPathEffect : public SkPairPathEffect
{
Same as compose path.

[egdaniel, 2015-01-23 20:58:34]

disregard previous comments. lgtm

[robertphillips, 2015-01-26 13:17:06]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-01-26 13:17:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/872043002/1

[commit-bot: I haz the power, 2015-01-26 13:18:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-26 13:18:06]

Failed to apply patch for include/core/SkShader.h:
While running git apply --index -3 -p1;
  error: patch failed: include/core/SkShader.h:478
  Falling back to three-way merge...
  Applied patch to 'include/core/SkShader.h' with conflicts.
  U include/core/SkShader.h

Patch:       include/core/SkShader.h
Index: include/core/SkShader.h
diff --git a/include/core/SkShader.h b/include/core/SkShader.h
index
f8de276c7bff4836a36f5298e1e551c6ef86be41..fea29eb1e3e1f8492c7711763505e0bab9eb0ceb
100644
--- a/include/core/SkShader.h
+++ b/include/core/SkShader.h
@@ -478,7 +478,7 @@ public:
      */
     virtual SkShader* refAsALocalMatrixShader(SkMatrix* localMatrix) const;
 
-    SK_TO_STRING_VIRT()
+    SK_TO_STRING_PUREVIRT()
     SK_DEFINE_FLATTENABLE_TYPE(SkShader)
 
 protected:

[robertphillips, 2015-01-26 13:21:30]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-01-26 13:22:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/872043002/20001

[commit-bot: I haz the power, 2015-01-26 13:22:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-26 13:22:18]

Presubmit check for 872043002-20001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

Was the presubmit check useful? If not, run "git cl presubmit -v"
to figure out which PRESUBMIT.py was run, then run git blame
on the file to figure out who to ask for help.

[robertphillips, 2015-01-26 13:26:10]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2015-01-26 13:26:42]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-01-26 13:27:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/872043002/20001

[robertphillips, 2015-01-26 13:28:27]

The CQ bit was unchecked by robertphillips@google.com

[robertphillips, 2015-01-26 14:07:50]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-01-26 14:08:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/872043002/20001

[commit-bot: I haz the power, 2015-01-26 14:08:56]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/42dbfa8651861f2f686879c996aab9f9f82277dd