tools/auto_bisect/bisect_perf_regression.py - Issue 872033003: Handling test failures on re-test of good/bad revisions for confidence.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/auto_bisect/bisect_perf_regression.py

Issue 872033003: Handling test failures on re-test of good/bad revisions for confidence. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/auto_bisect/bisect_perf_regression.py

diff --git a/tools/auto_bisect/bisect_perf_regression.py b/tools/auto_bisect/bisect_perf_regression.py

index f30ceb01d335f2483ddf0e9aae47c5e644aef7c0..8f4ec334c39a716e935d8a148a1e859fc087f27e 100755

--- a/tools/auto_bisect/bisect_perf_regression.py

+++ b/tools/auto_bisect/bisect_perf_regression.py

@@ -2480,7 +2480,13 @@ class BisectPerformanceMetrics(object):

metric,

test_run_multiplier=BORDER_REVISIONS_EXTRA_RUNS)

# Is extend the right thing to do here?

- state.value['values'].extend(run_results[0]['values'])

+ if run_results[1] != BUILD_RESULT_FAIL:

+ state.value['values'].extend(run_results[0]['values'])

+ else:

+ warning_text = "Re-test of revision %s failed with error message: %s"

qyearsley 2015/02/05 19:21:38 Nit: single quotes are preferred (just for consist

+ warning_text %= (state.revision, run_results[0])

qyearsley 2015/02/05 19:21:38 Cool, for some reason I haven't seen this done any

+ if warning_text not in self.warnings:

+ self.warnings.append(warning_text)

def _IsPlatformSupported():

« no previous file with comments | « no previous file | no next file » | no next file with comments »