Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: chrome/android/java/res/values-v17/styles.xml

Issue 872023002: Use floating labels for preference forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change repack_locales condition to just enable_autofill_dialog Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/values-v17/styles.xml
diff --git a/chrome/android/java/res/values-v17/styles.xml b/chrome/android/java/res/values-v17/styles.xml
index ce635c6af9e7b72b0249c1c2dcf7be0d7eac59f3..ebfb51192833a0ac4ab2576884505d0fe431de9a 100644
--- a/chrome/android/java/res/values-v17/styles.xml
+++ b/chrome/android/java/res/values-v17/styles.xml
@@ -51,6 +51,7 @@
<item name="android:textColor">?android:attr/textColorSecondary</item>
</style>
<style name="PreferenceScreenLayout">
+ <item name="android:paddingTop">16dp</item>
<item name="android:paddingStart">16dp</item>
<item name="android:paddingEnd">16dp</item>
</style>
@@ -66,6 +67,14 @@
<style name="DeprecationWarningPreferenceTheme" parent="PreferencesTheme">
<item name="android:textSize">14sp</item>
</style>
+ <style name="PreferenceFloatLabelTextAppearance">
newt (away) 2015/01/27 01:45:05 In PreferencesTheme, you can set PreferenceFloatLa
Theresa 2015/01/28 02:05:40 Done.
+ <item name="android:textColor">@color/float_label</item>
+ <item name="android:textSize">14sp</item>
+ </style>
+ <style name="PreferenceTextFieldLabel" parent="@style/BoldTextFieldLabel">
newt (away) 2015/01/27 01:45:05 When is this style used vs the other? Could you po
Theresa 2015/01/28 02:05:40 It was being used for the labels above the spinner
+ <item name="android:textStyle">normal</item>
+ <item name="android:textColor">@color/secondary_text_default_material_light</item>
+ </style>
<style name="ThemeWithActionBar" parent="Theme.AppCompat.Light.DarkActionBar">
<item name="android:windowBackground">@android:color/white</item>

Powered by Google App Engine
This is Rietveld 408576698