Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Unified Diff: chrome/android/java/res/layout/autofill_profile_editor.xml

Issue 872023002: Use floating labels for preference forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Re-fix findbugs Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/autofill_profile_editor.xml
diff --git a/chrome/android/java/res/layout/autofill_profile_editor.xml b/chrome/android/java/res/layout/autofill_profile_editor.xml
index 6c26d133ff5c4866f9b6f3f1ae5d66f6d03c34e0..75a750cf780ee3cdab18e958e1576acff940c7ae 100644
--- a/chrome/android/java/res/layout/autofill_profile_editor.xml
+++ b/chrome/android/java/res/layout/autofill_profile_editor.xml
@@ -4,6 +4,7 @@
found in the LICENSE file. -->
<ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
+ xmlns:app="http://schemas.android.com/apk/res-auto"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:fillViewport="true" >
@@ -21,6 +22,16 @@
android:orientation="vertical">
<!-- Editable fields for the profile -->
+ <TextView
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:textAppearance="@style/PreferenceFloatLabelTextAppearance"
+ android:text="@string/autofill_profile_editor_country" />
+ <Spinner
+ android:id="@+id/countries"
+ android:layout_width="fill_parent"
+ android:layout_height="wrap_content"
+ android:contentDescription="@string/autofill_profile_editor_country" />
<LinearLayout
android:id="@+id/autofill_profile_widget_root"
@@ -29,29 +40,35 @@
android:orientation="vertical" >
</LinearLayout>
- <TextView
- style="@style/BoldTextFieldLabel"
- android:text="@string/autofill_profile_editor_phone_number" />
-
- <EditText
- android:id="@+id/autofill_profile_editor_phone_number_edit"
+ <org.chromium.chrome.browser.widget.FloatLabelLayout
+ android:id="@+id/phone_number_label"
android:layout_width="match_parent"
- android:layout_height="wrap_content"
- android:imeOptions="flagNoExtractUi"
- android:inputType="phone"
- android:singleLine="true" />
+ android:layout_height="wrap_content" >
+ <EditText
+ android:id="@+id/phone_number_edit"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:imeOptions="flagNoExtractUi"
+ android:inputType="phone"
+ android:singleLine="true"
+ android:hint="@string/autofill_profile_editor_phone_number"
+ android:contentDescription="@string/autofill_profile_editor_phone_number" />
+ </org.chromium.chrome.browser.widget.FloatLabelLayout>
- <TextView
- style="@style/BoldTextFieldLabel"
- android:text="@string/autofill_profile_editor_email_address" />
-
- <EditText
- android:id="@+id/autofill_profile_editor_email_address_edit"
+ <org.chromium.chrome.browser.widget.FloatLabelLayout
+ android:id="@+id/email_address_label"
android:layout_width="match_parent"
- android:layout_height="wrap_content"
- android:imeOptions="flagNoExtractUi"
- android:inputType="textEmailAddress"
- android:singleLine="true" />
+ android:layout_height="wrap_content" >
+ <EditText
+ android:id="@+id/email_address_edit"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:imeOptions="flagNoExtractUi"
+ android:inputType="textEmailAddress"
+ android:singleLine="true"
+ android:hint="@string/autofill_profile_editor_email_address"
+ android:contentDescription="@string/autofill_profile_editor_email_address" />
+ </org.chromium.chrome.browser.widget.FloatLabelLayout>
</LinearLayout>

Powered by Google App Engine
This is Rietveld 408576698