chrome/browser/android/preferences/autofill/DEPS - Issue 872023002: Use floating labels for preference forms

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/android/preferences/autofill/DEPS

Issue 872023002: Use floating labels for preference forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change repack_locales condition to just enable_autofill_dialog Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 include_rules = [

	2 "+third_party/libaddressinput/src/cpp/include/libaddressinput/address_ui.h",
	newt (away) 2015/01/27 01:45:06 It's probably fine to use a single rule here ("+th It's probably fine to use a single rule here ("+third_party/libaddressinput/src/cpp/include/libaddressinput"). I'm not sure whether that's preferred, though. Theresa 2015/01/28 02:05:41 I think it's fine too, since it's included like t Show quoted text On 2015/01/27 01:45:06, newt wrote: > It's probably fine to use a single rule here > ("+third_party/libaddressinput/src/cpp/include/libaddressinput"). I'm not sure > whether that's preferred, though. > I think it's fine too, since it's included like that in src/chrome/browser/ui/autofill/DEPS. Possibly even preferred because then if we want to modify autofill_profile_bridge to use another class in libaddressinput, we don't have to remember to update this DEPS file (not properly updating this is only noticeable when tryjobs fail to compile).
	3 "+third_party/libaddressinput/src/cpp/include/libaddressinput/address_ui_compo nent.h",

	4 "+third_party/libaddressinput/src/cpp/include/libaddressinput/localization.h",

	5 ]

OLD	NEW