chrome/android/java/res/layout/preference_address_float_label_layout.xml - Issue 872023002: Use floating labels for preference forms

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/preference_address_float_label_layout.xml

Issue 872023002: Use floating labels for preference forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Re-fix findbugs Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/layout/homepage_preferences.xml ('k') | chrome/android/java/res/values-v17/styles.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
	newt (away) 2015/01/29 20:00:37 2015 2015 Theresa 2015/01/29 22:31:11 Done. Show quoted text On 2015/01/29 20:00:37, newt wrote: > 2015 Done.
	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <org.chromium.chrome.browser.widget.FloatLabelLayout

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 xmlns:app="http://schemas.android.com/apk/res-auto"
	newt (away) 2015/01/29 20:00:37 remove app namespace remove app namespace Theresa 2015/01/29 22:31:11 Done. Show quoted text On 2015/01/29 20:00:37, newt wrote: > remove app namespace Done.
	9 android:layout_width="match_parent"

	10 android:layout_height="wrap_content"

	11 android:id="@+id/float_label_layout" >
	newt (away) 2015/01/29 20:00:37 put id about layout_* attributes put id about layout_* attributes Theresa 2015/01/29 22:31:11 Done. Show quoted text On 2015/01/29 20:00:37, newt wrote: > put id about layout_* attributes Done.
	12 <EditText

	13 android:id="@+id/address_edit_text"

	14 android:singleLine="true"
	newt (away) 2015/01/29 20:00:37 put singleLine after layout_* attributes. put singleLine after layout_* attributes. Theresa 2015/01/29 22:31:11 Done. Show quoted text On 2015/01/29 20:00:37, newt wrote: > put singleLine after layout_* attributes. Done.
	15 android:layout_width="fill_parent"

	16 android:layout_height="wrap_content"

	17 android:inputType = "textPostalAddress\|textCapWords" />
	newt (away) 2015/01/29 20:00:37 remove spaces around "=" remove spaces around "=" Theresa 2015/01/29 22:31:11 Done. Show quoted text On 2015/01/29 20:00:37, newt wrote: > remove spaces around "=" Done.
	18 </org.chromium.chrome.browser.widget.FloatLabelLayout>

OLD	NEW