Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 871993003: check for too-large rowBytes (Closed)

Created:
5 years, 11 months ago by reed1
Modified:
5 years, 11 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : use cast to keep minRB signed (matching the rest of the code) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M src/core/SkMallocPixelRef.cpp View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M tests/BitmapTest.cpp View 1 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871993003/20001
5 years, 11 months ago (2015-01-23 15:00:50 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-23 15:00:50 UTC) #4
caryclark
https://codereview.chromium.org/871993003/diff/20001/src/core/SkMallocPixelRef.cpp File src/core/SkMallocPixelRef.cpp (right): https://codereview.chromium.org/871993003/diff/20001/src/core/SkMallocPixelRef.cpp#newcode59 src/core/SkMallocPixelRef.cpp:59: int64_t minRB = info.minRowBytes64(); signature returns uint64_t https://codereview.chromium.org/871993003/diff/20001/src/core/SkMallocPixelRef.cpp#newcode60 src/core/SkMallocPixelRef.cpp:60: ...
5 years, 11 months ago (2015-01-23 15:10:10 UTC) #5
reed1
https://codereview.chromium.org/871993003/diff/20001/src/core/SkMallocPixelRef.cpp File src/core/SkMallocPixelRef.cpp (right): https://codereview.chromium.org/871993003/diff/20001/src/core/SkMallocPixelRef.cpp#newcode59 src/core/SkMallocPixelRef.cpp:59: int64_t minRB = info.minRowBytes64(); On 2015/01/23 15:10:09, caryclark wrote: ...
5 years, 11 months ago (2015-01-23 15:35:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871993003/40001
5 years, 11 months ago (2015-01-23 15:35:50 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-23 15:35:53 UTC) #9
caryclark
lgtm
5 years, 11 months ago (2015-01-23 15:49:32 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 15:51:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/2ff257bd95c732b9cebc3aac03fbed72d6e6082a

Powered by Google App Engine
This is Rietveld 408576698