win: Make asan work with isolates.

win: Make asan work with isolates.

1. asan required disable_nacl=1 since there's no 64-bit runtime yet.
   disable_nacl=1 doesn't work with isolates.  Move the asan flags
   around a bit so that they're only applied to 32-bit targets.
   Now everything builds fine without disable_nacl=1

2. One isolate file was missing a <(EXECUTABLE_SUFFIX), add that.

BUG=416078
TEST=
* `ninja -C out\Release chrome_nacl_win64` builds correctly
* out\Release\obj\base\base.ninja still has asan flags,
  the base_unittests.exe link command still has asan flags

R=scottmg@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/b3c1328d585593445dd1b118685aa3497db9e5b0

[Nico, 2015-01-23 23:02:41]

thakis@chromium.org changed reviewers:
+ rnk@chromium.org, scottmg@chromium.org

[Nico, 2015-01-23 23:02:41]

First to stamp wins!

https://codereview.chromium.org/871973004/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/871973004/diff/1/build/common.gypi#newcode5576
build/common.gypi:5576: 'x86_Base': {
This is now in x86_Base instead of being in the default for "all" (32, 64)
targets.

[scottmg, 2015-01-23 23:04:48]

lgtm

[commit-bot: I haz the power, 2015-01-23 23:44:15]

Patchset 1 (id:??) landed as
https://crrev.com/b3c1328d585593445dd1b118685aa3497db9e5b0
Cr-Commit-Position: refs/heads/master@{#312967}

[Nico, 2015-01-23 23:44:27]

Committed patchset #1 (id:1) manually as
b3c1328d585593445dd1b118685aa3497db9e5b0 (presubmit successful).

[Timur Iskhodzhanov, 2015-01-24 06:36:00]

Am I right that using asan=1 on target_arch=x64 is now no-op?
Should we error out in that case?

[Nico, 2015-01-24 06:43:56]

On 2015/01/24 06:36:00, Timur Iskhodzhanov wrote:
> Am I right that using asan=1 on target_arch=x64 is now no-op?

Yes, for now.

> Should we error out in that case?

Dunno, we could. I doubt it matters much.