Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 871923005: Add scroll-blocks-on support to devtools layers view (Closed)

Created:
5 years, 11 months ago by Rick Byers
Modified:
5 years, 11 months ago
Reviewers:
caseq
CC:
blink-reviews, Dominik Röttsches, caseq+blink_chromium.org, blink-reviews-rendering, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, zoltan1, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, skobes, Ian Vollick
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add scroll-blocks-on support to devtools layers view Add missing decription of the scroll-blocks-on compositing reason to the devtools layers view. Also don't add the compositing reason to the root layer to avoid clutter. With force-compositing-mode shipped everywhere, this shouldn't effect whether compositing is actually enabled or not in practice. However it should avoid triggering compositing mode unnecessarily in experimental modes like OOPIF that don't enable it by default. BUG=347272 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188962

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M LayoutTests/inspector/layers/layer-compositing-reasons-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/LayerDetailsView.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
Rick Byers
caseq@ PTAL at this tiny devtools tweak. I missed updating the layers view when I ...
5 years, 11 months ago (2015-01-23 15:26:40 UTC) #2
caseq
lgtm
5 years, 11 months ago (2015-01-23 15:57:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871923005/1
5 years, 11 months ago (2015-01-23 16:02:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/47508)
5 years, 11 months ago (2015-01-23 17:56:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871923005/1
5 years, 11 months ago (2015-01-23 21:54:16 UTC) #9
commit-bot: I haz the power
Failed to commit the patch. svn: E155010: Commit failed (details follow): svn: E155010: '/b/infra_internal/commit_queue/workdir/blink/LayoutTests/paint/theme' is ...
5 years, 11 months ago (2015-01-23 22:44:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871923005/1
5 years, 11 months ago (2015-01-26 15:58:46 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 15:59:26 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188962

Powered by Google App Engine
This is Rietveld 408576698