Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 871893002: Script streaming: Test that streaming <-> harmony scopes interaction is correct. (Closed)

Created:
5 years, 11 months ago by marja
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Script streaming: Test that streaming <-> harmony scopes interaction is correct. BUG= Committed: https://crrev.com/c421f3de5455ca50cb0be5ada0e331ad9b9f124b Cr-Commit-Position: refs/heads/master@{#26250}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -4 lines) Patch
M test/cctest/test-api.cc View 2 chunks +45 lines, -4 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
marja
dslomov, ptal https://codereview.chromium.org/871893002/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/871893002/diff/1/test/cctest/test-api.cc#newcode24159 test/cctest/test-api.cc:24159: // Possible errors are only produced while ...
5 years, 11 months ago (2015-01-23 09:49:52 UTC) #2
Dmitry Lomov (no reviews)
lgtm
5 years, 11 months ago (2015-01-23 13:18:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871893002/1
5 years, 11 months ago (2015-01-23 14:11:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 14:41:10 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 14:41:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c421f3de5455ca50cb0be5ada0e331ad9b9f124b
Cr-Commit-Position: refs/heads/master@{#26250}

Powered by Google App Engine
This is Rietveld 408576698