Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 871853003: Reset privet destination loading when destination store is reset (Closed)

Created:
5 years, 10 months ago by tbarzic
Modified:
5 years, 10 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset privet destination loading when destination store is reset Resetting destination store will clear all destinations. If hasLoadedAllPrivetDestinations is not reset, privet destination list will not get repopulated after reset_ (provided that the privet destination loading had previously finished) BUG=None TEST= On network with some privet printers setup: 1. Open print preview (Ctrl+P) and try to change selected destination 2. There should be some privet printers listed under "Local destinations" 3. When local destination loading is done (the spinner disappears) add another account 4. Make sure "Local Destinations" list gets repopulated with privet printers Committed: https://crrev.com/8b6ea075495daf178afc48e4aee8f5375df16bc2 Cr-Commit-Position: refs/heads/master@{#314176}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/resources/print_preview/data/destination_store.js View 2 chunks +3 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (3 generated)
tbarzic
5 years, 10 months ago (2015-01-31 00:57:23 UTC) #2
Vitaly Buka (NO REVIEWS)
5 years, 10 months ago (2015-02-02 17:22:54 UTC) #4
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 10 months ago (2015-02-02 17:23:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871853003/1
5 years, 10 months ago (2015-02-02 19:19:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 19:23:46 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8b6ea075495daf178afc48e4aee8f5375df16bc2 Cr-Commit-Position: refs/heads/master@{#314176}
5 years, 10 months ago (2015-02-02 19:24:32 UTC) #9
tbarzic
5 years, 10 months ago (2015-02-02 20:19:17 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/871853003/diff/1/chrome/browser/resources/pri...
File chrome/browser/resources/print_preview/data/destination_store.js (right):

https://codereview.chromium.org/871853003/diff/1/chrome/browser/resources/pri...
chrome/browser/resources/print_preview/data/destination_store.js:488: if
(this.privetDestinationSearchInProgress_)
oops, this should go before we set this.privetDestinationSearchInProgress_ to
true :/
I'll fix it in the next patch.

Powered by Google App Engine
This is Rietveld 408576698