Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: content/browser/service_worker/service_worker_provider_host.cc

Issue 871853002: ServiceWorker: add ServiceWorkerClients.claim() support (2/3). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove listener Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_provider_host.cc
diff --git a/content/browser/service_worker/service_worker_provider_host.cc b/content/browser/service_worker/service_worker_provider_host.cc
index 6153b93a747902920cd1602d5151efd0853a289b..1fefdd3b9dbb68620da5ff8025b437182203afb3 100644
--- a/content/browser/service_worker/service_worker_provider_host.cc
+++ b/content/browser/service_worker/service_worker_provider_host.cc
@@ -92,6 +92,11 @@ void ServiceWorkerProviderHost::OnSkippedWaiting(
SetControllerVersionAttribute(active_version);
}
+void ServiceWorkerProviderHost::ClaimedByNewVersion() {
+ DCHECK(controlling_version_ != associated_registration_->active_version());
+ SetControllerVersionAttribute(associated_registration_->active_version());
+}
+
void ServiceWorkerProviderHost::SetDocumentUrl(const GURL& url) {
DCHECK(!url.has_ref());
document_url_ = url;
@@ -117,7 +122,8 @@ void ServiceWorkerProviderHost::SetControllerVersionAttribute(
return; // Could be NULL in some tests.
bool should_notify_controllerchange =
- previous_version && version && version->skip_waiting();
+ (version && version->claiming_clients()) ||
+ (previous_version && version && version->skip_waiting());
dispatcher_host_->Send(new ServiceWorkerMsg_SetControllerServiceWorker(
kDocumentMainThreadId, provider_id(),
@@ -150,10 +156,7 @@ bool ServiceWorkerProviderHost::SetHostedVersionId(int64 version_id) {
void ServiceWorkerProviderHost::AssociateRegistration(
ServiceWorkerRegistration* registration) {
DCHECK(CanAssociateRegistration(registration));
- if (associated_registration_.get())
- DecreaseProcessReference(associated_registration_->pattern());
IncreaseProcessReference(registration->pattern());
-
associated_registration_ = registration;
associated_registration_->AddListener(this);
SendAssociateRegistrationMessage();

Powered by Google App Engine
This is Rietveld 408576698