ServiceWorker: add ServiceWorkerClients.claim() support (2/3).

content/browser/service_worker/service_worker_provider_host.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_PROVIDER_HOST_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_PROVIDER_HOST_H_
 
 #include <set>
 #include <vector>
 
@@ skipping 76 matching lines @@
   ServiceWorkerVersion* running_hosted_version() const {
     return running_hosted_version_.get();
   }
 
   void SetDocumentUrl(const GURL& url);
   const GURL& document_url() const { return document_url_; }
 
   void SetTopmostFrameUrl(const GURL& url);
   const GURL& topmost_frame_url() const { return topmost_frame_url_; }
 
+  // Starts using the |registration| which means the active worker will
+  // control this provider.
+  void UseRegistration(ServiceWorkerRegistration* registration);

[falken, 2015/01/28 08:59:49]

This is better, but I'm still not a fan of this name. The user of this class
will likely be unsure when to use UseRegistration or AssociateRegistration.

I like Michael's suggestion:
- "first rejigger the associated registrations" (AssociateRegistration)
- "then notify them of the being claimed by a new version"
(OnClaimedByNewVersion)

[xiang, 2015/01/29 02:58:37]

You are right, the "use" will confuse people without the spec context. I will
change it.
The OnClaimedByNewVersion() seems not needed, if we make a "claiming" flag in
version.

+
   // Associates to |registration| to listen for its version change events.

[falken, 2015/01/28 08:59:49]

It's not part of your patch, but this class no longer listens for version change
events.

   void AssociateRegistration(ServiceWorkerRegistration* registration);
 
   // Clears the associated registration and stop listening to it.
   void DisassociateRegistration();
 
   // Returns false if the version is not in the expected STARTING in our
   // process state. That would be indicative of a bad IPC message.
   bool SetHostedVersionId(int64 versions_id);
 
   // Returns a handler for a request, the handler may return NULL if
@@ skipping 83 matching lines @@
   base::WeakPtr<ServiceWorkerContextCore> context_;
   ServiceWorkerDispatcherHost* dispatcher_host_;
   bool allow_association_;
 
   DISALLOW_COPY_AND_ASSIGN(ServiceWorkerProviderHost);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_PROVIDER_HOST_H_