Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 871843009: Revert of Added bluetooth LE support on Mac platform (Closed)

Created:
5 years, 10 months ago by ccameron
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added bluetooth LE support on Mac platform (patchset #13 id:340001 of https://codereview.chromium.org/791763005/) Reason for revert: Breaks compile: http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/17750 ../../device/bluetooth/bluetooth_low_energy_discovery_manager_mac.mm:119:30: error: class method '+UUIDWithString:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access] CBUUID* uuid = [CBUUID UUIDWithString:uuidString]; ^~~~~~~~~~~~~~ ../../device/bluetooth/bluetooth_low_energy_device_mac.mm:82:39: error: use of undeclared identifier 'CBAdvertisementDataIsConnectable' [advertisementData objectForKey:CBAdvertisementDataIsConnectable]; ^ ../../device/bluetooth/bluetooth_low_energy_device_mac.mm:85:39: error: use of undeclared identifier 'CBAdvertisementDataServiceDataKey' [advertisementData objectForKey:CBAdvertisementDataServiceDataKey]; ^ 2 errors generated. Original issue's description: > Added bluetooth LE support on Mac platform > > BUG=449682 > > Committed: https://crrev.com/42f79f8b08a99190627f3a67e86a378987104a4a > Cr-Commit-Position: refs/heads/master@{#315190} TBR=armansito@chromium.org,avi@chromium.org,groby@chromium.org,dvh@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=449682 Committed: https://crrev.com/46b4983d6119b1e4b0c441c61fcbe10b4eb56335 Cr-Commit-Position: refs/heads/master@{#315191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -688 lines) Patch
M base/mac/sdk_forward_declarations.h View 4 chunks +0 lines, -58 lines 0 comments Download
M device/bluetooth/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_discovery_manager_mac.h View 1 chunk +0 lines, -3 lines 0 comments Download
D device/bluetooth/bluetooth_low_energy_device_mac.h View 1 chunk +0 lines, -99 lines 0 comments Download
D device/bluetooth/bluetooth_low_energy_device_mac.mm View 1 chunk +0 lines, -237 lines 0 comments Download
D device/bluetooth/bluetooth_low_energy_discovery_manager_mac.h View 1 chunk +0 lines, -103 lines 0 comments Download
D device/bluetooth/bluetooth_low_energy_discovery_manager_mac.mm View 1 chunk +0 lines, -180 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ccameron
Created Revert of Added bluetooth LE support on Mac platform
5 years, 10 months ago (2015-02-07 08:33:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871843009/1
5 years, 10 months ago (2015-02-07 08:33:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-07 08:33:48 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 08:34:25 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46b4983d6119b1e4b0c441c61fcbe10b4eb56335
Cr-Commit-Position: refs/heads/master@{#315191}

Powered by Google App Engine
This is Rietveld 408576698