Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: test/unittests/test-utils.h

Issue 871843004: Distinquish TestWithIsolateAndZone from TestWithZone (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@no_zone_isolate
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/unittests/compiler/schedule-unittest.cc ('k') | test/unittests/test-utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/test-utils.h
diff --git a/test/unittests/test-utils.h b/test/unittests/test-utils.h
index 718fd5ac5977e8e6cc999418264af31de1cfb9e3..765b97dd3798b0d9fecfaefd5750bd6a5eae1ece 100644
--- a/test/unittests/test-utils.h
+++ b/test/unittests/test-utils.h
@@ -90,7 +90,7 @@ class TestWithIsolate : public virtual ::v8::TestWithIsolate {
};
-class TestWithZone : public TestWithIsolate {
+class TestWithZone : public virtual ::testing::Test {
public:
TestWithZone() {}
virtual ~TestWithZone();
@@ -103,6 +103,21 @@ class TestWithZone : public TestWithIsolate {
DISALLOW_COPY_AND_ASSIGN(TestWithZone);
};
+
+class TestWithIsolateAndZone : public virtual TestWithIsolate {
+ public:
+ TestWithIsolateAndZone() {}
+ virtual ~TestWithIsolateAndZone();
+
+ Zone* zone() { return &zone_; }
+
+ private:
+ Zone zone_;
+
+ DISALLOW_COPY_AND_ASSIGN(TestWithIsolateAndZone);
+};
+
+
} // namespace internal
} // namespace v8
« no previous file with comments | « test/unittests/compiler/schedule-unittest.cc ('k') | test/unittests/test-utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698