Issue 871843004: Distinquish TestWithIsolateAndZone from TestWithZone

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 871843004: Distinquish TestWithIsolateAndZone from TestWithZone (Closed)

Created:
5 years, 11 months ago by danno

Modified:
5 years, 11 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@no_zone_isolate

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Distinquish TestWithIsolateAndZone from TestWithZone Allows unit tests that just need a zone and no isolate to avoid the overhead of creating one. R=mstarzinger@chromium.org LOG=N Committed: https://crrev.com/d1e45d9b00c5c3620f80a7f32d7edb2c65cb36f7 Cr-Commit-Position: refs/heads/master@{#26256}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -5 lines)			Patch
M	test/unittests/compiler/graph-unittest.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/unittests/compiler/instruction-selector-unittest.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/unittests/compiler/instruction-sequence-unittest.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/unittests/compiler/schedule-unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/unittests/test-utils.h	View	2 chunks	+16 lines, -1 line	0 comments	Download
M	test/unittests/test-utils.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871843004/1

5 years, 11 months ago (2015-01-23 16:09:14 UTC) #4

commit-bot: I haz the power

5 years, 11 months ago (2015-01-23 16:30:10 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d1e45d9b00c5c3620f80a7f32d7edb2c65cb36f7
Cr-Commit-Position: refs/heads/master@{#26256}