Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 871833002: Revert of QUIC - Deleted disable_loading_server_info_for_new_servers field trial. (Closed)

Created:
5 years, 11 months ago by benwells
Modified:
5 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of QUIC - Deleted disable_loading_server_info_for_new_servers field trial. (patchset #2 id:40001 of https://codereview.chromium.org/858323002/) Reason for revert: This caused a compile failure on iOS bots. http://build.chromium.org/p/chromium.mac/builders/iOS%20Device/builds/21417 Error from log copied below: Undefined symbols for architecture armv7: "net::QuicStreamFactory::QuicStreamFactory(net::HostResolver*, net::ClientSocketFactory*, base::WeakPtr<net::HttpServerProperties>, net::CertVerifier*, net::ChannelIDService*, net::TransportSecurityState*, net::QuicCryptoClientStreamFactory*, net::QuicRandom*, net::QuicClock*, unsigned long, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<net::QuicVersion, std::__1::allocator<net::QuicVersion> > const&, bool, bool, bool, int, bool, float, bool, std::__1::vector<unsigned int, std::__1::allocator<unsigned int> > const&)", referenced from: net::test::QuicStreamFactoryTest::QuicStreamFactoryTest() in quic_stream_factory_test.o ld: symbol(s) not found for architecture armv7 clang:error: linker command failed with exit code 1 (use -v to see invocation) Original issue's description: > QUIC - Deleted disable_loading_server_info_for_new_servers field trial. > Changed the code not to load server config if there is no alternative > protocol entry for QUIC. During our experiments, we found that > disable_loading_server_info_for_new_servers being set to true has > reduced the latency until crypto handshake completion. > > This is a revert of https://codereview.chromium.org/811073004/ > > We check for alternative protocols only if there is a http_server_properties_ object. > > R=rch@chromium.org > > Committed: https://crrev.com/6a454624b8f2827af3ec154bb96e61e7fdcf9e3a > Cr-Commit-Position: refs/heads/master@{#312741} TBR=rch@chromium.org,rtenneti@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/ec5c9bbcd707a2b3a852346bc21e90c8f32ab5d2 Cr-Commit-Position: refs/heads/master@{#312748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1 line) Patch
M chrome/browser/io_thread.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/io_thread.cc View 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/io_thread_unittest.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_network_session.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.h View 2 chunks +6 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 3 chunks +4 lines, -1 line 0 comments Download
M net/quic/quic_stream_factory_test.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
benwells
Created Revert of QUIC - Deleted disable_loading_server_info_for_new_servers field trial.
5 years, 11 months ago (2015-01-23 03:04:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871833002/1
5 years, 11 months ago (2015-01-23 03:07:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 03:12:14 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ec5c9bbcd707a2b3a852346bc21e90c8f32ab5d2 Cr-Commit-Position: refs/heads/master@{#312748}
5 years, 11 months ago (2015-01-23 03:13:57 UTC) #4
ramant (doing other things)
On 2015/01/23 03:13:57, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 11 months ago (2015-01-23 17:43:28 UTC) #5
ramant (doing other things)
On 2015/01/23 17:43:28, ramant wrote: > On 2015/01/23 03:13:57, I haz the power (commit-bot) wrote: ...
5 years, 11 months ago (2015-01-23 20:10:14 UTC) #6
ramant (doing other things)
lgtm Relanded the change.
5 years, 11 months ago (2015-01-23 20:10:38 UTC) #7
ramant (doing other things)
5 years, 11 months ago (2015-01-23 20:10:40 UTC) #8
Message was sent while issue was closed.
lgtm

Relanded the change.

Powered by Google App Engine
This is Rietveld 408576698