Fix popup window repositioning in Desktop Chrome.

ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/desktop_aura/desktop_native_widget_aura.h"
 
 #include "base/bind.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/client/cursor_client.h"
 #include "ui/aura/client/window_tree_client.h"
 #include "ui/aura/test/test_window_delegate.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_tree_host.h"
 #include "ui/events/test/event_generator.h"
+#include "ui/gfx/screen.h"
 #include "ui/views/test/views_test_base.h"
 #include "ui/views/test/widget_test.h"
 #include "ui/views/widget/widget.h"
 #include "ui/wm/public/dispatcher_client.h"
 
 namespace views {
 namespace test {
 
 typedef ViewsTestBase DesktopNativeWidgetAuraTest;
 
@@ skipping 362 matching lines @@
   gfx::Rect new_size(0, 0, 400, 400);
   popup_window.owned_window()->SetBounds(new_size);
 
   EXPECT_EQ(popup_window.top_level_widget()->GetNativeView()->bounds().size(),
             new_size.size());
   RunPendingMessages();
   ASSERT_NO_FATAL_FAILURE(popup_window.DestroyOwnedWindow());
   RunPendingMessages();
 }
 
+// This test validates that when a top level owned popup Aura window is
+// repositioned, the widget is repositioned as well.
+TEST_F(DesktopAuraWidgetTest, TopLevelOwnedPopupRepositionTest) {
+  ViewsDelegate::views_delegate = NULL;
+  DesktopAuraTopLevelWindowTest popup_window;
+  ASSERT_NO_FATAL_FAILURE(popup_window.CreateTopLevelWindow(
+      gfx::Rect(0, 0, 200, 200), false));
+
+  gfx::Rect new_pos(10, 10, 400, 400);
+  popup_window.owned_window()->SetBoundsInScreen(
+      new_pos,
+      gfx::Screen::GetScreenFor(
+          popup_window.owned_window())->GetDisplayNearestPoint(gfx::Point()));
+
+  EXPECT_EQ(popup_window.top_level_widget()->GetWindowBoundsInScreen(),

[sky, 2015/01/23 17:38:50]

new_pos should be first (argument order is expected, actual).

[ananta, 2015/01/23 19:37:11]

Done.

+            new_pos);
+  RunPendingMessages();

[sky, 2015/01/23 17:38:50]

Why the RunPendingMessages?

[ananta, 2015/01/23 19:37:11]

Stupid cut paste. Removed the first RunPendingMessages from this test and the
TopLevelOwnedPopupResizeTest test. We need the second one to ensure that the
popup window is destroyed before we enter the dtor of the
DesktopAuraTopLevelWindowTest class

[sky, 2015/01/23 20:29:21]

Why do we need to wait for the destruction?

+  ASSERT_NO_FATAL_FAILURE(popup_window.DestroyOwnedWindow());
+  RunPendingMessages();
+}
+
 }  // namespace test
 }  // namespace views