Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 871813002: Delete redundant gpu_unittests_run target and gpu_unittests.isolate. (Closed)

Created:
5 years, 11 months ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete redundant gpu_unittests_run target and gpu_unittests.isolate. The copies in src/chrome/ were left over from a previous attempt to put them on the GPU try servers. These tests are still running on the chromium.gpu.fyi waterfall. The isolate's build target will be picked up from src/gpu/gpu.gyp. BUG=451180 Committed: https://crrev.com/61bf2ae6b70c0395bb9309ba4c187b9eeee32bc0 Cr-Commit-Position: refs/heads/master@{#313009}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/gpu_unittests.isolate View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
Ken Russell (switch to Gerrit)
maruel or csharp: OWNERS review of deletion of isolate please. zmo or bajones: review of ...
5 years, 11 months ago (2015-01-23 22:26:37 UTC) #2
Zhenyao Mo
On 2015/01/23 22:26:37, Ken Russell wrote: > maruel or csharp: OWNERS review of deletion of ...
5 years, 11 months ago (2015-01-23 22:35:02 UTC) #3
bajones
lgtm
5 years, 11 months ago (2015-01-23 23:06:08 UTC) #4
M-A Ruel
rubberstamp lgtm
5 years, 11 months ago (2015-01-24 00:09:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871813002/1
5 years, 11 months ago (2015-01-24 02:59:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/38111) Try jobs failed on following ...
5 years, 11 months ago (2015-01-24 03:05:07 UTC) #9
Ken Russell (switch to Gerrit)
On 2015/01/24 03:05:07, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 11 months ago (2015-01-24 03:32:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871813002/1
5 years, 11 months ago (2015-01-24 03:33:38 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/38111)
5 years, 11 months ago (2015-01-24 03:33:57 UTC) #14
Ken Russell (switch to Gerrit)
crbug.com/451675 filed for the apparent bug in the presubmit checks. src/chrome OWNERS: OWNERS review please. ...
5 years, 11 months ago (2015-01-24 05:18:01 UTC) #16
Nico
rs-lgtm
5 years, 11 months ago (2015-01-24 05:19:46 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871813002/1
5 years, 11 months ago (2015-01-24 05:20:40 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-24 05:24:25 UTC) #20
commit-bot: I haz the power
5 years, 11 months ago (2015-01-24 05:25:17 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61bf2ae6b70c0395bb9309ba4c187b9eeee32bc0
Cr-Commit-Position: refs/heads/master@{#313009}

Powered by Google App Engine
This is Rietveld 408576698