Issue 871773003: Remove @keyframe parsing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 871773003: Remove @keyframe parsing. (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove @keyframe parsing. We still have the code internally, but the parser won't create StyleRuleKeyframes anymore. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f88b6f3adffe5f81ea9e3293e1e3fdf2f33bfbb0

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -169 lines)			Patch
M	sky/engine/core/css/parser/CSSGrammar.y	View	13 chunks	+2 lines, -120 lines	0 comments	Download
M	sky/engine/core/css/parser/CSSTokenizer-in.cpp	View	3 chunks	+1 line, -13 lines	0 comments	Download
D	sky/tests/animation/basic-declarative.sky	View	1 chunk	+0 lines, -31 lines	0 comments	Download
D	sky/tests/animation/basic-declarative-expected.txt	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 3 (1 generated)

esprehn

5 years, 11 months ago (2015-01-23 04:48:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f88b6f3adffe5f81ea9e3293e1e3fdf2f33bfbb0 (presubmit successful).