Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gpu/command_buffer/service/gpu_tracer_unittest.cc

Issue 871763002: Make GL bindings conditional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc ('K') | « gpu/command_buffer/service/gpu_service_test.cc ('k') | gpu/command_buffer/service/memory_program_cache_unittest.cc » ('j') | third_party/khronos/README.chromium » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gpu_tracer_unittest.cc
diff --git a/gpu/command_buffer/service/gpu_tracer_unittest.cc b/gpu/command_buffer/service/gpu_tracer_unittest.cc
index 1b55e785e4517576c002fbd6fc90183d4582c150..30067b6eb4b002e5e076e8f215927cb9eef6cf95 100644
--- a/gpu/command_buffer/service/gpu_tracer_unittest.cc
+++ b/gpu/command_buffer/service/gpu_tracer_unittest.cc
@@ -225,7 +225,10 @@ class BaseGpuTest : public GpuServiceTest {
protected:
void SetUp() override {
- GpuServiceTest::SetUp();
+ // TODO: The tracer code is wrong and assumes that getInteger64v
+ // is available when timer_query or disjoint_timer exists.
+ GpuServiceTest::SetUpWithGLVersion(
+ "3.2", "GL_EXT_disjoint_timer_query GL_ARB_timer_query");
gl_fake_queries_.Reset();
gl_surface_ = new gfx::GLSurfaceStub();
gl_context_ = new gfx::GLContextStub();
« gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc ('K') | « gpu/command_buffer/service/gpu_service_test.cc ('k') | gpu/command_buffer/service/memory_program_cache_unittest.cc » ('j') | third_party/khronos/README.chromium » ('J')

Powered by Google App Engine
This is Rietveld 408576698