Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 871713002: Remove NaClPluginLowLevelInitializationComplete() (caller of "init_done" SRPC) (Closed)

Created:
5 years, 11 months ago by Mark Seaborn
Modified:
5 years, 11 months ago
CC:
native-client-reviews_googlegroups.com, teravest
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Remove NaClPluginLowLevelInitializationComplete() (caller of "init_done" SRPC) The call to this function has been removed from the Chromium side. The "init_done" SRPC call used to trigger a call to StartPpapiProxy(), but Chromium now starts PPAPI via a different route. This change should allow some further cleanups, such as disabling the imc_connect() syscall in Chromium. However, we'll need to push new PNaCl translator binaries first. The existing pre-built PNaCl translator binaries will still contain NaClPluginLowLevelInitializationComplete(), and disabling imc_connect() would trigger a LOG_FATAL error inside that function. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864 TEST=trybots + run some Chromium tests Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=c14b58a2c36c9377d4211433d896bd135dcc4a63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -132 lines) Patch
M src/shared/srpc/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M src/shared/srpc/accept.c View 2 chunks +0 lines, -2 lines 0 comments Download
M src/shared/srpc/accept_threaded.c View 2 chunks +0 lines, -2 lines 0 comments Download
M src/shared/srpc/nacl.scons View 1 chunk +0 lines, -2 lines 0 comments Download
D src/shared/srpc/nacl_srpc_ppapi_plugin_init.c View 1 chunk +0 lines, -19 lines 0 comments Download
D src/shared/srpc/nacl_srpc_ppapi_plugin_internal.h View 1 chunk +0 lines, -19 lines 0 comments Download
D src/shared/srpc/nacl_srpc_ppapi_plugin_internal.c View 1 chunk +0 lines, -84 lines 0 comments Download
M src/shared/srpc/srpc.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Mark Seaborn
5 years, 11 months ago (2015-01-23 16:47:38 UTC) #2
jvoung (off chromium)
lgtm
5 years, 11 months ago (2015-01-23 17:04:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871713002/1
5 years, 11 months ago (2015-01-23 19:47:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: nacl-win32_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-win32_glibc_opt/builds/9436)
5 years, 11 months ago (2015-01-23 19:51:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871713002/1
5 years, 11 months ago (2015-01-23 22:17:27 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 22:36:27 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/native_client?view=rev&revision=c14b58a2c36c93...

Powered by Google App Engine
This is Rietveld 408576698