Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 871693002: MIPS: new classes: change semantics of super(...) call and add new.target to construct stub. (Closed)

Created:
5 years, 11 months ago by akos.palfi.imgtec
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: new classes: change semantics of super(...) call and add new.target to construct stub. Port 22ce08ade63a9c4f28225db11a5b5d2726c5a8e7 BUG= Committed: https://crrev.com/48cb56ab8bf16ebe965ea6188e50dfdce62b665e Cr-Commit-Position: refs/heads/master@{#26232}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -55 lines) Patch
M src/mips/builtins-mips.cc View 5 chunks +42 lines, -23 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 chunks +54 lines, -5 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 5 chunks +42 lines, -22 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 2 chunks +54 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
akos.palfi.imgtec
PTAL.
5 years, 11 months ago (2015-01-22 22:14:43 UTC) #2
paul.l...
LGTM, but please fix the nits. https://codereview.chromium.org/871693002/diff/1/src/mips/full-codegen-mips.cc File src/mips/full-codegen-mips.cc (right): https://codereview.chromium.org/871693002/diff/1/src/mips/full-codegen-mips.cc#newcode3241 src/mips/full-codegen-mips.cc:3241: // Load function ...
5 years, 11 months ago (2015-01-22 23:42:24 UTC) #3
akos.palfi.imgtec
https://codereview.chromium.org/871693002/diff/1/src/mips/full-codegen-mips.cc File src/mips/full-codegen-mips.cc (right): https://codereview.chromium.org/871693002/diff/1/src/mips/full-codegen-mips.cc#newcode3241 src/mips/full-codegen-mips.cc:3241: // Load function and argument count into r1 and ...
5 years, 11 months ago (2015-01-23 00:26:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871693002/20001
5 years, 11 months ago (2015-01-23 00:28:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-23 05:46:13 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 05:46:29 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/48cb56ab8bf16ebe965ea6188e50dfdce62b665e
Cr-Commit-Position: refs/heads/master@{#26232}

Powered by Google App Engine
This is Rietveld 408576698