Issue 871683002: Remove a number of unused features from WebViewImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 871683002: Remove a number of unused features from WebViewImpl (Closed)

Created:
5 years, 11 months ago by abarth-chromium

Modified:
5 years, 11 months ago

Reviewers:
esprehn

CC:
esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove a number of unused features from WebViewImpl This CL removes a bunch of unused code from WebViewImpl. The bulk of the code is to let C++ drive scroll flights, but we're going to implement that using gesture events and having the scroll driven in script. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6eaa7bc4bc5e5252cdc55be803c1093731bf05c0

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -421 lines)			Patch
M	sky/engine/core/page/EventHandler.cpp	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	sky/engine/core/page/Page.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/page/Page.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/platform/BUILD.gn	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	sky/engine/platform/exported/WebActiveGestureAnimation.h	View	1 chunk	+0 lines, -64 lines	0 comments	Download
D	sky/engine/platform/exported/WebActiveGestureAnimation.cpp	View	1 chunk	+0 lines, -67 lines	0 comments	Download
M	sky/engine/public/BUILD.gn	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/public/platform/Platform.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
D	sky/engine/public/platform/WebGestureCurve.h	View	1 chunk	+0 lines, -46 lines	0 comments	Download
D	sky/engine/public/platform/WebGestureCurveTarget.h	View	1 chunk	+0 lines, -43 lines	0 comments	Download
M	sky/engine/public/platform/WebLayerTreeView.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/engine/public/web/WebSettings.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/public/web/WebView.h	View	2 chunks	+0 lines, -13 lines	0 comments	Download
M	sky/engine/web/WebSettingsImpl.h	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	sky/engine/web/WebSettingsImpl.cpp	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	sky/engine/web/WebViewImpl.h	View	6 chunks	+0 lines, -13 lines	0 comments	Download
M	sky/engine/web/WebViewImpl.cpp	View	9 chunks	+0 lines, -130 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 11 months ago (2015-01-22 22:58:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6eaa7bc4bc5e5252cdc55be803c1093731bf05c0 (presubmit successful).

Expand Messages | Collapse Messages