content/browser/permissions/permission_service_impl.cc - Issue 871663003: media: Add MediaPermission interface and MediaPermissionDispatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/permissions/permission_service_impl.cc

Issue 871663003: media: Add MediaPermission interface and MediaPermissionDispatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove test code. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | content/common/permission_service.mojom » ('j') | content/renderer/media/media_permission_dispatcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/permissions/permission_service_impl.cc

diff --git a/content/browser/permissions/permission_service_impl.cc b/content/browser/permissions/permission_service_impl.cc

index 7d9464e00941e61ba36f24dbfaa7b6dc2e52cd2f..0124d007e50c49ff23016f1f955c911dd76d7d92 100644

--- a/content/browser/permissions/permission_service_impl.cc

+++ b/content/browser/permissions/permission_service_impl.cc

@@ -18,6 +18,8 @@ PermissionType PermissionNameToPermissionType(PermissionName name) {

return PERMISSION_MIDI_SYSEX;

case PERMISSION_NAME_NOTIFICATIONS:

return PERMISSION_NOTIFICATIONS;

+ case PERMISSION_NAME_PROTECTED_MEDIA_IDENTIFIER:

+ return PERMISSION_PROTECTED_MEDIA;

xhwang 2015/01/22 23:40:54 We have some inconsistency here: PROTECTED_MEDIA_

sandersd (OOO until July 31) 2015/01/24 00:49:21 I agree, consistency is good, and the identifier s

xhwang 2015/01/26 21:49:06 sg; I'll update the name in a separate CL.

}

NOTREACHED();