Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 871643005: Remove the old versions of the Push API headers. (Closed)

Created:
5 years, 10 months ago by Peter Beverloo
Modified:
5 years, 10 months ago
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove the old versions of the Push API headers. These are no longer necessary now that Chromium uses the new paths. This is part of a three-sided patch: [1] https://codereview.chromium.org/888513003/ [2] https://codereview.chromium.org/894683002/ [3] This patch. BUG=453032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189842

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
D public/platform/WebPushClient.h View 1 chunk +0 lines, -1 line 0 comments Download
D public/platform/WebPushError.h View 1 chunk +0 lines, -1 line 0 comments Download
D public/platform/WebPushPermissionStatus.h View 1 chunk +0 lines, -1 line 0 comments Download
D public/platform/WebPushProvider.h View 1 chunk +0 lines, -1 line 0 comments Download
D public/platform/WebPushRegistration.h View 1 1 chunk +0 lines, -1 line 0 comments Download
D public/platform/WebPushSubscription.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Peter Beverloo
+mvanouwerkerk for Push API. +jochen for the public/ module changes for Push API (removal of ...
5 years, 10 months ago (2015-02-02 12:51:15 UTC) #2
Mike West
LGTM.
5 years, 10 months ago (2015-02-02 13:19:15 UTC) #4
Michael van Ouwerkerk
lgtm
5 years, 10 months ago (2015-02-02 14:00:05 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-04 12:34:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871643005/20001
5 years, 10 months ago (2015-02-09 19:54:37 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 21:21:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189842

Powered by Google App Engine
This is Rietveld 408576698