Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 871643003: Remove PageWidgetDelegate (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
esprehn, eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove PageWidgetDelegate There's only one page widget delegate: WebView. R=eseidel@chromium.org, esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dc23588ad57b981bb07bbeef55c56772f7b48c8a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -338 lines) Patch
M sky/engine/web/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/web/ChromeClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
D sky/engine/web/PageWidgetDelegate.h View 1 chunk +0 lines, -84 lines 0 comments Download
D sky/engine/web/PageWidgetDelegate.cpp View 1 chunk +0 lines, -215 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 4 chunks +10 lines, -16 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 9 chunks +119 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
abarth-chromium
5 years, 11 months ago (2015-01-22 23:30:29 UTC) #1
eseidel
lgtm
5 years, 11 months ago (2015-01-22 23:31:04 UTC) #4
abarth-chromium
5 years, 11 months ago (2015-01-22 23:31:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dc23588ad57b981bb07bbeef55c56772f7b48c8a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698