Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 871623002: Move FP texture test buffers to heap. (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
Reviewers:
jvanverth1, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Move FP texture test buffers to heap. This is a speculative fix for the crashing N5 bots. It looks like the bots are always failing in or around FloatingPointTextureTest. It looks like sometimes they're hitting a SIGBUS, which I suspect is stack overflow. FloatingPointTextureTest allocates ~320K on the stack, which may be too much. This CL moves those buffers to the heap. For consistency I did the same with the half-float tests, though they're only using ~1/8th the stack. It looks like sometimes the bots are failing to malloc. I don't understand that, and this CL doesn't address that directly. But it's possible this is still a stack overflow, just trashing RAM and causing arbitrary mayhem instead of a SIGBUS. I have no idea why this is a problem only on the N5. I have been unable to reproduce this locally, neither with a K N5 nor an L N5, but the bots are pretty reliable. NOTREECHECKS=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/cada95ad9b8e6be9bdffe1a70968a2102cc3f09d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M tests/FloatingPointTextureTest.cpp View 4 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
5 years, 11 months ago (2015-01-22 21:37:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871623002/1
5 years, 11 months ago (2015-01-22 21:38:32 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-22 21:38:33 UTC) #5
jvanverth1
lgtm
5 years, 11 months ago (2015-01-22 21:44:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871623002/1
5 years, 11 months ago (2015-01-22 21:50:31 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 21:50:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cada95ad9b8e6be9bdffe1a70968a2102cc3f09d

Powered by Google App Engine
This is Rietveld 408576698