Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 871613002: Revert of cc: Trigger deadline immediately when commit is aborted. (Closed)

Created:
5 years, 11 months ago by sunnyps
Modified:
5 years, 11 months ago
Reviewers:
brianderson
CC:
chromium-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Trigger deadline immediately when commit is aborted. (patchset #3 id:40001 of https://codereview.chromium.org/822933004/) Reason for revert: caused major regression in tough_compositor_cases crbug.com/450897 Original issue's description: > cc: Trigger deadline immediately when commit is aborted. > > The scheduler should trigger it's deadline immediately if there's no > more work to be done in a given frame. This happens for instance when a > commit is aborted and there's nothing to draw. > > BUG=432981 > > Committed: https://crrev.com/7f6eb54c666afea307ad3035c404e00692cacbf1 > Cr-Commit-Position: refs/heads/master@{#311404} TBR=brianderson@chromium.org BUG=432981 Committed: https://crrev.com/bb330dba04f2b332a8a1607d5ade33c17235125c Cr-Commit-Position: refs/heads/master@{#312746}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -35 lines) Patch
M cc/scheduler/scheduler_state_machine.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
sunnyps
Created Revert of cc: Trigger deadline immediately when commit is aborted.
5 years, 11 months ago (2015-01-22 20:43:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871613002/1
5 years, 11 months ago (2015-01-22 20:44:35 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 11 months ago (2015-01-22 20:44:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871613002/1
5 years, 11 months ago (2015-01-22 20:45:28 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 11 months ago (2015-01-22 20:45:30 UTC) #9
brianderson
lgtm
5 years, 11 months ago (2015-01-22 20:46:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871613002/1
5 years, 11 months ago (2015-01-22 20:47:30 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (None) Exceeded time limit waiting for ...
5 years, 11 months ago (2015-01-22 22:49:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871613002/1
5 years, 11 months ago (2015-01-22 23:49:35 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (None) mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/26028)
5 years, 11 months ago (2015-01-22 23:51:31 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871613002/1
5 years, 11 months ago (2015-01-23 03:01:49 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 03:10:33 UTC) #21
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 03:12:15 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb330dba04f2b332a8a1607d5ade33c17235125c
Cr-Commit-Position: refs/heads/master@{#312746}

Powered by Google App Engine
This is Rietveld 408576698