Issue 871603002: Reenable goma on OSX now that pnacl issues are fixed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 871603002: Reenable goma on OSX now that pnacl issues are fixed. (Closed)

Created:
5 years, 11 months ago by M-A Ruel

Modified:
5 years, 11 months ago

Reviewers:
Sébastien Marchand

CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build

Target Ref:
refs/heads/master

Project:
tools

Visibility:
Public.

Reenable goma on OSX now that pnacl issues are fixed. There are still known issue with remove_build_metadata being executed after isolate.py check is being run within the compile step, this will be addressed in a follow up. R=sebmarchand@chromium.org BUG=330262 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293756

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	scripts/slave/recipes/swarming/deterministic_build.py	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic_build.json	View		3 chunks	+7 lines, -3 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871603002/1

5 years, 11 months ago (2015-01-22 20:43:55 UTC) #4

commit-bot: I haz the power

5 years, 11 months ago (2015-01-22 20:46:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293756