Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 871563003: Fix ImageData constructor infelicity. (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
Reviewers:
haraken, Justin Novosad
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, arv+blink, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix ImageData constructor infelicity. Correctly handle the optional third argument for the overload ImageData(Uint8ClampedArray d, unsigned long w, optional unsigned long h) It should not throw if not supplied, but should throw if supplied and zero. Also, delegate the object interface typecheck to generated bindings code. R=junov BUG=338804 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188847

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -18 lines) Patch
M LayoutTests/fast/canvas/canvas-ImageData-constructor-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-ImageData-workers-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/resources/canvas-ImageData.js View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/ImageData.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/html/ImageData.cpp View 1 chunk +38 lines, -17 lines 0 comments Download
M Source/core/html/ImageData.idl View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
Please take a look.
5 years, 11 months ago (2015-01-22 20:25:50 UTC) #2
Justin Novosad
On 2015/01/22 20:25:50, sof wrote: > Please take a look. lgtm
5 years, 11 months ago (2015-01-22 20:58:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871563003/1
5 years, 11 months ago (2015-01-22 21:03:52 UTC) #5
haraken
LGTM
5 years, 11 months ago (2015-01-23 01:20:44 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 02:36:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188847

Powered by Google App Engine
This is Rietveld 408576698