Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 871563002: Generalize PreviewPanelModel so that it stops to refer specific cloud-import CSS class. (Closed)

Created:
5 years, 11 months ago by hirono
Modified:
5 years, 11 months ago
Reviewers:
mtomasz, Steve McKay
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Generalize PreviewPanelModel so that it stops to refer specific cloud-import CSS class. BUG=438947 TEST=FileManagerJsTest.PreviewPanelModelTest Committed: https://crrev.com/7cee0b39e08ad7c272f096350d2763d654eec97c Cr-Commit-Position: refs/heads/master@{#312682}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M ui/file_manager/file_manager/foreground/js/preview_panel_model.js View 3 chunks +6 lines, -6 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/preview_panel_model_unittest.js View 1 1 chunk +8 lines, -10 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
hirono
PTAL the CL? Thanks!
5 years, 11 months ago (2015-01-22 19:35:52 UTC) #2
mtomasz
lgtm with a nit https://codereview.chromium.org/871563002/diff/1/ui/file_manager/file_manager/foreground/js/preview_panel_model_unittest.js File ui/file_manager/file_manager/foreground/js/preview_panel_model_unittest.js (right): https://codereview.chromium.org/871563002/diff/1/ui/file_manager/file_manager/foreground/js/preview_panel_model_unittest.js#newcode10 ui/file_manager/file_manager/foreground/js/preview_panel_model_unittest.js:10: var TIMEOUT_MS = 3000; nit: ...
5 years, 11 months ago (2015-01-22 19:46:45 UTC) #3
hirono
Thanks! https://codereview.chromium.org/871563002/diff/1/ui/file_manager/file_manager/foreground/js/preview_panel_model_unittest.js File ui/file_manager/file_manager/foreground/js/preview_panel_model_unittest.js (right): https://codereview.chromium.org/871563002/diff/1/ui/file_manager/file_manager/foreground/js/preview_panel_model_unittest.js#newcode10 ui/file_manager/file_manager/foreground/js/preview_panel_model_unittest.js:10: var TIMEOUT_MS = 3000; On 2015/01/22 19:46:45, mtomasz ...
5 years, 11 months ago (2015-01-22 19:48:50 UTC) #4
Steve McKay
lgtm
5 years, 11 months ago (2015-01-22 20:46:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871563002/20001
5 years, 11 months ago (2015-01-22 21:27:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-22 21:40:45 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 21:41:57 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7cee0b39e08ad7c272f096350d2763d654eec97c
Cr-Commit-Position: refs/heads/master@{#312682}

Powered by Google App Engine
This is Rietveld 408576698