Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 871543003: [Android] mostly deprecate craigdh and frankf from OWNERS (Closed)

Created:
5 years, 10 months ago by jbudorick
Modified:
5 years, 10 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, stgao, yfriedman+watch_chromium.org, samuong+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] mostly deprecate craigdh and frankf from OWNERS BUG= Committed: https://crrev.com/f7a80a7a918ff65ec95c944734a060e88a380e40 Cr-Commit-Position: refs/heads/master@{#313542}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M build/android/pylib/device/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/uiautomator_tests/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/OWNERS View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/ispy/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/android_testrunner/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/webdriver/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (2 generated)
jbudorick
exterminate
5 years, 10 months ago (2015-01-28 00:31:09 UTC) #2
craigdh
s/deprecate/wipe from all memory/g lgtm, and good luck!
5 years, 10 months ago (2015-01-28 00:40:18 UTC) #3
jbudorick
On 2015/01/28 00:40:18, craigdh wrote: > s/deprecate/wipe from all memory/g > > lgtm, and good ...
5 years, 10 months ago (2015-01-28 00:56:33 UTC) #4
frankf
https://codereview.chromium.org/871543003/diff/1/chrome/test/chromedriver/OWNERS File chrome/test/chromedriver/OWNERS (left): https://codereview.chromium.org/871543003/diff/1/chrome/test/chromedriver/OWNERS#oldcode4 chrome/test/chromedriver/OWNERS:4: stgao@chromium.org actually can you leave me here. I may ...
5 years, 10 months ago (2015-01-28 00:59:19 UTC) #5
jbudorick
https://codereview.chromium.org/871543003/diff/1/chrome/test/chromedriver/OWNERS File chrome/test/chromedriver/OWNERS (left): https://codereview.chromium.org/871543003/diff/1/chrome/test/chromedriver/OWNERS#oldcode4 chrome/test/chromedriver/OWNERS:4: stgao@chromium.org On 2015/01/28 00:59:19, frankf wrote: > actually can ...
5 years, 10 months ago (2015-01-28 01:02:01 UTC) #6
frankf
lgtm
5 years, 10 months ago (2015-01-28 01:03:53 UTC) #7
Ted C
lgtm
5 years, 10 months ago (2015-01-28 01:48:57 UTC) #8
samuong
lgtm
5 years, 10 months ago (2015-01-28 02:08:00 UTC) #9
perezju
On 2015/01/28 02:08:00, samuong wrote: > lgtm lgtm
5 years, 10 months ago (2015-01-28 10:13:36 UTC) #10
klundberg
lgtm
5 years, 10 months ago (2015-01-28 16:26:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871543003/20001
5 years, 10 months ago (2015-01-28 16:27:02 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-28 18:22:50 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 18:23:42 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f7a80a7a918ff65ec95c944734a060e88a380e40
Cr-Commit-Position: refs/heads/master@{#313542}

Powered by Google App Engine
This is Rietveld 408576698