Add device policy to disallow shutdown - WebUI modifications

Add device policy to disallow shutdown - WebUI modifications

This CL is a follow-up to 776093004 and 811033002 and wires up the UI (WebUI only!) to the disallow shutdown policy.

BUG=312541
TEST=Full browser- and unit-test coverage

WebUI

BUG=

Committed: https://crrev.com/67e162acd95e04f1867781e127c12afb42090cb6
Cr-Commit-Position: refs/heads/master@{#313017}

[cschuet (SLOW), 2015-01-23 14:01:35]

cschuet@chromium.org changed reviewers:
+ oshima@chromium.org, ygorshenin@chromium.org

[cschuet (SLOW), 2015-01-23 14:01:36]

oshima@chromium.org: Please review changes in 
ash/system/date/*
chrome/browser/chromeos/settings/*
chrome/browser/chromeos/shutdown_policy_browsertest.cc
chrome/chrome_tests.gypi

ygorshenin@chromium.org: Please review changes in 
chrome/browser/chromeos/settings/shutdown_policy_handler.cc
chrome/browser/resources/*
chrome/browser/ui/webui/*
chrome/app/chromeos_strings.grdp

[ygorshenin1, 2015-01-23 15:29:36]

LGTM as soon as comments will be addressed.

https://codereview.chromium.org/871483003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/shutdown_policy_browsertest.cc (right):

https://codereview.chromium.org/871483003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/shutdown_policy_browsertest.cc:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
nit: s/2014/2015

https://codereview.chromium.org/871483003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/shutdown_policy_browsertest.cc:75: virtual
~ShutdownPolicyBaseTest() {}
Please, use override here instead of virtual. The same for other virtual
destructors in the file.

https://codereview.chromium.org/871483003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/shutdown_policy_browsertest.cc:78: virtual void
OwnershipStatusChanged() override {}
nit: you can remove 'virtual' keyword since you've already specified 'override'?
The same for other overridden virtual methods in the file.

https://codereview.chromium.org/871483003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/shutdown_policy_browsertest.cc:128: void
WaitForOobeIO(OobeUI* oobe_ui) {
How about to rename the method to WaitUntilOobeUIIsReady()?

https://codereview.chromium.org/871483003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/shutdown_policy_browsertest.cc:165: void
GetShutdownButton(const ash::TrayPopupHeaderButton** shutdown_button) {
Could you please modify the function to return a pointer instead of modification
of an argument?

https://codereview.chromium.org/871483003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/shutdown_policy_browsertest.cc:177:
scoped_ptr<ash::DateDefaultView> date_default_view_;
As this field is not used by derived classes, could you please move it to the
private section of the class?

[cschuet (SLOW), 2015-01-23 16:33:03]

https://codereview.chromium.org/871483003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/shutdown_policy_browsertest.cc (right):

https://codereview.chromium.org/871483003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/shutdown_policy_browsertest.cc:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
On 2015/01/23 15:29:36, ygorshenin1 wrote:
> nit: s/2014/2015

Done.

https://codereview.chromium.org/871483003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/shutdown_policy_browsertest.cc:75: virtual
~ShutdownPolicyBaseTest() {}
On 2015/01/23 15:29:36, ygorshenin1 wrote:
> Please, use override here instead of virtual. The same for other virtual
> destructors in the file.

Done.

https://codereview.chromium.org/871483003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/shutdown_policy_browsertest.cc:78: virtual void
OwnershipStatusChanged() override {}
On 2015/01/23 15:29:36, ygorshenin1 wrote:
> nit: you can remove 'virtual' keyword since you've already specified
'override'?
> The same for other overridden virtual methods in the file.

Done.

https://codereview.chromium.org/871483003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/shutdown_policy_browsertest.cc:128: void
WaitForOobeIO(OobeUI* oobe_ui) {
On 2015/01/23 15:29:36, ygorshenin1 wrote:
> How about to rename the method to WaitUntilOobeUIIsReady()?

Done.

https://codereview.chromium.org/871483003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/shutdown_policy_browsertest.cc:165: void
GetShutdownButton(const ash::TrayPopupHeaderButton** shutdown_button) {
On 2015/01/23 15:29:36, ygorshenin1 wrote:
> Could you please modify the function to return a pointer instead of
modification
> of an argument?

Done.

https://codereview.chromium.org/871483003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/shutdown_policy_browsertest.cc:177:
scoped_ptr<ash::DateDefaultView> date_default_view_;
On 2015/01/23 15:29:36, ygorshenin1 wrote:
> As this field is not used by derived classes, could you please move it to the
> private section of the class?

Done.

[oshima, 2015-01-23 21:43:37]

lgtm with nits

https://codereview.chromium.org/871483003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/shutdown_policy_browsertest.cc (right):

https://codereview.chromium.org/871483003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/shutdown_policy_browsertest.cc:171: int message_id) {
nit: const method?

https://codereview.chromium.org/871483003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/shutdown_policy_browsertest.cc:175: }
new line between } and private:

https://codereview.chromium.org/871483003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/shutdown_policy_browsertest.cc:248: private:
nit: move his before member variables

https://codereview.chromium.org/871483003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/shutdown_policy_browsertest.cc:272:
~ShutdownPolicyLoginTest() override {}
nit: new line

[cschuet (SLOW), 2015-01-24 10:18:41]

The CQ bit was checked by cschuet@chromium.org

[cschuet (SLOW), 2015-01-24 10:18:53]

https://codereview.chromium.org/871483003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/shutdown_policy_browsertest.cc (right):

https://codereview.chromium.org/871483003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/shutdown_policy_browsertest.cc:171: int message_id) {
On 2015/01/23 21:43:37, oshima wrote:
> nit: const method?

Done.

https://codereview.chromium.org/871483003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/shutdown_policy_browsertest.cc:175: }
On 2015/01/23 21:43:37, oshima wrote:
> new line between } and private:

Done.

https://codereview.chromium.org/871483003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/shutdown_policy_browsertest.cc:248: private:
On 2015/01/23 21:43:37, oshima wrote:
> nit: move his before member variables

Done.

https://codereview.chromium.org/871483003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/shutdown_policy_browsertest.cc:272:
~ShutdownPolicyLoginTest() override {}
On 2015/01/23 21:43:37, oshima wrote:
> nit: new line 

Done.

[commit-bot: I haz the power, 2015-01-24 10:19:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/871483003/60001

[commit-bot: I haz the power, 2015-01-24 12:27:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-24 12:28:09]

Patchset 4 (id:??) landed as
https://crrev.com/67e162acd95e04f1867781e127c12afb42090cb6
Cr-Commit-Position: refs/heads/master@{#313017}