Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 871473002: Rename and turn fast/multicol/span/clone-summary.html into a reftest. (Closed)

Created:
5 years, 11 months ago by mstensho (USE GERRIT)
Modified:
5 years, 11 months ago
Reviewers:
andersr
CC:
mstensho (USE GERRIT), blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename and turn fast/multicol/span/clone-summary.html into a reftest. The name "clone-summary" wasn't exactly great for the new multicol implementation, since nothing gets cloned there. Still a useful test, though, since SUMMARY is always a block (even if attempted displayed as table-row) and there's a spanner cutting right through it. BUG=386567 R=andersr@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -48 lines) Patch
M LayoutTests/FlakyTests View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/TestExpectations View 2 chunks +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/multicol/span/clone-summary.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/multicol/span/clone-summary-expected.png View Binary file 0 comments Download
D LayoutTests/fast/multicol/span/clone-summary-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
A LayoutTests/fast/multicol/span/summary-split.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/span/summary-split-expected.html View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mstensho (USE GERRIT)
5 years, 11 months ago (2015-01-26 12:54:50 UTC) #1
andersr
lgtm
5 years, 11 months ago (2015-01-27 09:56:08 UTC) #2
andersr
lgtm lgtm
5 years, 11 months ago (2015-01-27 09:56:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871473002/1
5 years, 11 months ago (2015-01-27 09:57:15 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 10:04:06 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189017

Powered by Google App Engine
This is Rietveld 408576698