Issue 871433008: Update mhtml saved page header to "Saved by Blink"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 871433008: Update mhtml saved page header to "Saved by Blink" (Closed)

Created:
5 years, 10 months ago by samahto

Modified:
5 years, 10 months ago

Reviewers:
darin (slow to review), eseidel, jochen (gone - plz use gerrit), pdr., eae

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Update mhtml saved page header to "Saved by Blink" BUG=None TEST=NONE Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189613

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/platform/mhtml/MHTMLArchive.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871433008/1

5 years, 10 months ago (2015-02-06 03:23:11 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=189613

5 years, 10 months ago (2015-02-06 04:42:12 UTC) #6

pdr.

5 years, 10 months ago (2015-02-06 22:37:20 UTC) #7

Message was sent while issue was closed.

On 2015/02/06 at 04:42:12, commit-bot wrote:
> Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189613

I'm surprised we don't have any tests for this.

@samahto, this isn't something you caused but would you be up for writing a test
so we have some coverage of this area?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages