Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 871383002: Merge HTMLDocument into Document (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
eseidel1
CC:
eseidel, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Merge HTMLDocument into Document HTMLDocument is the same as Document. We can merge them. R=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/63c0d5ce01f7cc03f3bfd912ce8d24ce64d63210

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -756 lines) Patch
M sky/engine/bindings/core/v8/ScriptController.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8DOMWrapper.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/bindings/core/v8/WindowProxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/bindings/core/v8/WindowProxy.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/bindings/core/v8/custom/V8WindowCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/bindings/templates/interface.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/app/ModuleLoader.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/core.gni View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/parser/CSSGrammar.y View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/parser/CSSParserMode.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/dom/Document.h View 4 chunks +1 line, -13 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 9 chunks +9 lines, -20 lines 0 comments Download
M sky/engine/core/dom/Document.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Element.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/core/fetch/CachingCorrectnessTest.cpp View 1 chunk +0 lines, -543 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 2 chunks +1 line, -2 lines 0 comments Download
D sky/engine/core/html/HTMLDocument.h View 1 chunk +0 lines, -48 lines 0 comments Download
D sky/engine/core/html/HTMLDocument.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
D sky/engine/core/html/HTMLDocument.idl View 1 chunk +0 lines, -23 lines 0 comments Download
M sky/engine/core/html/imports/HTMLImportLoader.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/html/parser/HTMLDocumentParser.h View 3 chunks +2 lines, -3 lines 0 comments Download
M sky/engine/core/html/parser/HTMLDocumentParser.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/html/parser/HTMLTreeBuilder.h View 2 chunks +2 lines, -3 lines 0 comments Download
M sky/engine/core/html/parser/HTMLTreeBuilder.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/public/web/WebDocument.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebDocument.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 11 months ago (2015-01-26 07:34:13 UTC) #1
eseidel1
lgtm
5 years, 11 months ago (2015-01-26 07:34:36 UTC) #3
abarth-chromium
5 years, 11 months ago (2015-01-26 07:48:57 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
63c0d5ce01f7cc03f3bfd912ce8d24ce64d63210 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698