Child accounts icons added to Chrome OS notifications.

Child accounts icons added to Chrome OS notifications.

BUG=434643
TBR=jennyz@chromium.org

Committed: https://crrev.com/72a49c1e70b07101c1a22161914adc297a4d0e42
Cr-Commit-Position: refs/heads/master@{#313897}

[merkulova, 2015-01-27 10:02:11]

merkulova@chromium.org changed reviewers:
+ dzhioev@chromium.org, jennyz@chromium.org, oshima@chromium.org

[merkulova, 2015-01-27 10:03:21]

dzhioev@ as user_pod_row.* files owner and general review
jennyz@ as ash/system/chromeos owner
oshima@ as owner for assets and *.grd files

[oshima, 2015-01-27 10:36:47]

lgtm with nits

https://codereview.chromium.org/871373011/diff/1/ash/system/chromeos/supervis...
File ash/system/chromeos/supervised/tray_supervised_user.cc (right):

https://codereview.chromium.org/871373011/diff/1/ash/system/chromeos/supervis...
ash/system/chromeos/supervised/tray_supervised_user.cc:124: int
TraySupervisedUser::GetSupervisedUserIconId() {
can this be const?

https://codereview.chromium.org/871373011/diff/1/chrome/app/theme/theme_resou...
File chrome/app/theme/theme_resources.grd (right):

https://codereview.chromium.org/871373011/diff/1/chrome/app/theme/theme_resou...
chrome/app/theme/theme_resources.grd:483: <structure type="chrome_scaled_image"
name="IDR_CHILD_USER_ICON" file="common/child_user_invert.png" />
sort by id

[merkulova, 2015-01-27 16:39:48]

https://codereview.chromium.org/871373011/diff/1/ash/system/chromeos/supervis...
File ash/system/chromeos/supervised/tray_supervised_user.cc (right):

https://codereview.chromium.org/871373011/diff/1/ash/system/chromeos/supervis...
ash/system/chromeos/supervised/tray_supervised_user.cc:124: int
TraySupervisedUser::GetSupervisedUserIconId() {
On 2015/01/27 10:36:47, oshima wrote:
> can this be const?

Done.

https://codereview.chromium.org/871373011/diff/1/chrome/app/theme/theme_resou...
File chrome/app/theme/theme_resources.grd (right):

https://codereview.chromium.org/871373011/diff/1/chrome/app/theme/theme_resou...
chrome/app/theme/theme_resources.grd:483: <structure type="chrome_scaled_image"
name="IDR_CHILD_USER_ICON" file="common/child_user_invert.png" />
On 2015/01/27 10:36:47, oshima wrote:
> sort by id

Done.

[dzhioev (left Google), 2015-01-27 19:33:27]

Hello.

Please run 'tools/resources/optimize-png-files.sh' for added png files.

https://codereview.chromium.org/871373011/diff/20001/ash/system/chromeos/supe...
File ash/system/chromeos/supervised/tray_supervised_user.cc (right):

https://codereview.chromium.org/871373011/diff/20001/ash/system/chromeos/supe...
ash/system/chromeos/supervised/tray_supervised_user.cc:60: if
(!delegate->IsUserSupervised())
Does GetIsUserChild imply IsUserSupervised?

https://codereview.chromium.org/871373011/diff/20001/ash/system/chromeos/supe...
ash/system/chromeos/supervised/tray_supervised_user.cc:131: return -1;
I think we need CHECK here.

[merkulova, 2015-01-28 15:10:54]

Compressed the pngs. PTAL

https://codereview.chromium.org/871373011/diff/20001/ash/system/chromeos/supe...
File ash/system/chromeos/supervised/tray_supervised_user.cc (right):

https://codereview.chromium.org/871373011/diff/20001/ash/system/chromeos/supe...
ash/system/chromeos/supervised/tray_supervised_user.cc:60: if
(!delegate->IsUserSupervised())
On 2015/01/27 19:33:26, dzhioev wrote:
> Does GetIsUserChild imply IsUserSupervised?
 Yes.

https://codereview.chromium.org/871373011/diff/20001/ash/system/chromeos/supe...
ash/system/chromeos/supervised/tray_supervised_user.cc:131: return -1;
On 2015/01/27 19:33:27, dzhioev wrote:
> I think we need CHECK here.

Done.

[dzhioev (left Google), 2015-01-29 14:18:16]

On 2015/01/28 15:10:54, merkulova wrote:
> Compressed the pngs. PTAL
> 
>
https://codereview.chromium.org/871373011/diff/20001/ash/system/chromeos/supe...
> File ash/system/chromeos/supervised/tray_supervised_user.cc (right):
> 
>
https://codereview.chromium.org/871373011/diff/20001/ash/system/chromeos/supe...
> ash/system/chromeos/supervised/tray_supervised_user.cc:60: if
> (!delegate->IsUserSupervised())
> On 2015/01/27 19:33:26, dzhioev wrote:
> > Does GetIsUserChild imply IsUserSupervised?
>  Yes.
> 
>
https://codereview.chromium.org/871373011/diff/20001/ash/system/chromeos/supe...
> ash/system/chromeos/supervised/tray_supervised_user.cc:131: return -1;
> On 2015/01/27 19:33:27, dzhioev wrote:
> > I think we need CHECK here.
> 
> Done.

LGTM

[merkulova, 2015-01-30 10:24:12]

merkulova@chromium.org changed reviewers:
- jennyz@chromium.org

[merkulova, 2015-01-30 10:24:53]

Moving jennyz@ to TBR.

[merkulova, 2015-01-30 10:25:09]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2015-01-30 10:25:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/871373011/40001

[commit-bot: I haz the power, 2015-01-30 11:15:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-30 11:16:49]

Patchset 3 (id:??) landed as
https://crrev.com/72a49c1e70b07101c1a22161914adc297a4d0e42
Cr-Commit-Position: refs/heads/master@{#313897}