Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 871373010: [turbofan] Only replace nodes eagerly during simplified lowering if the types stay the same. (Closed)

Created:
5 years, 11 months ago by Jarin
Modified:
5 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Only replace nodes eagerly during simplified lowering if the types stay the same. BUG=chromium:452427 LOG=n R=bmeurer@chromium.org Committed: https://crrev.com/b4a4c4c5911aabe326c472a3225f439ed4954f75 Cr-Commit-Position: refs/heads/master@{#26286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M src/compiler/simplified-lowering.cc View 1 chunk +6 lines, -4 lines 0 comments Download
A test/mjsunit/compiler/regress-452427.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
lgtm
5 years, 11 months ago (2015-01-27 09:04:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871373010/1
5 years, 11 months ago (2015-01-27 09:04:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 09:27:34 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 09:27:48 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4a4c4c5911aabe326c472a3225f439ed4954f75
Cr-Commit-Position: refs/heads/master@{#26286}

Powered by Google App Engine
This is Rietveld 408576698