Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 871353003: Revert of Revert of Special check on Supervised User creation flow added to prevent misleading .. (Closed)

Created:
5 years, 10 months ago by merkulova
Modified:
5 years, 10 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Special check on Supervised User creation flow added to prevent misleading shelf alignment. (patchset #1 id:1 of https://codereview.chromium.org/830393004/) Reason for revert: The bug is not reproducible anymore. Some fixes to shelf were done earlier, may be that prevents that one problem Original issue's description: > Revert of Special check on Supervised User creation flow added to prevent misleading shelf alignment. (patchset #3 id:40001 of https://codereview.chromium.org/783663003/) > > Reason for revert: > Appears to have caused bug 446212 > > Original issue's description: > > Special check on Supervised User creation flow added to prevent misleading shelf alignment. > > > > BUG=405361 > > > > Committed: https://crrev.com/e2b59c4c229ec214150f522f4b3f6b02d9cefaee > > Cr-Commit-Position: refs/heads/master@{#309555} > > TBR=dzhioev@chromium.org,skuhne@chromium.org,merkulova@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=405361 > > Committed: https://crrev.com/e2e8ff56d1937bb635884032534def9fc42b7809 > Cr-Commit-Position: refs/heads/master@{#310145} TBR=dzhioev@chromium.org,skuhne@chromium.org,abodenha@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=405361 Committed: https://crrev.com/835a430d6e435aa73354669ab2f18ce1cff4bf5e Cr-Commit-Position: refs/heads/master@{#314540}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ash/shelf/shelf_layout_manager.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
merkulova
Created Revert of Revert of Special check on Supervised User creation flow added to prevent ...
5 years, 10 months ago (2015-02-04 11:45:23 UTC) #1
Mr4D (OOO till 08-26)
lgtm
5 years, 10 months ago (2015-02-05 00:46:22 UTC) #2
dzhioev (left Google)
5 years, 10 months ago (2015-02-05 13:20:12 UTC) #3
On 2015/02/05 00:46:22, Mr4D (TOK time) wrote:
> lgtm

lgtm

Powered by Google App Engine
This is Rietveld 408576698