Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 871293003: Update {virtual,override,final} to follow C++11 style in gpu. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in gpu. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Committed: https://crrev.com/e608bf1db146501034def593a8f5880d94d1c24a Cr-Commit-Position: refs/heads/master@{#314998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -22 lines) Patch
M gpu/command_buffer/client/gl_in_process_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/stream_texture_manager_in_process_android.cc View 1 chunk +15 lines, -15 lines 0 comments Download
M gpu/command_buffer/tests/gl_unittests_android.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dcheng
5 years, 10 months ago (2015-02-06 01:05:25 UTC) #2
piman
lgtm
5 years, 10 months ago (2015-02-06 03:38:31 UTC) #3
dcheng
lgtm
5 years, 10 months ago (2015-02-06 06:37:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871293003/1
5 years, 10 months ago (2015-02-06 06:38:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 07:33:15 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 07:34:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e608bf1db146501034def593a8f5880d94d1c24a
Cr-Commit-Position: refs/heads/master@{#314998}

Powered by Google App Engine
This is Rietveld 408576698